Update Arcade TFMs according to TFM docs #14332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ViktorHofer
commented
Jan 2, 2024
•
ViktorHofer
commented
- Use "Tool" floating TFM properties for msbuild tasks and tools, i.e. Microsoft.DotNet.Arcade.Sdk.
- Use "Minimum" floating TFM properties for libraries that support previous framework versions, i.e. XUnitExtensions.
- Use "Current" floating TFM properties for libraries that support only the current framework version.
ViktorHofer
commented
Jan 2, 2024
| @@ -1,8 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netstandard2.0</TargetFramework> | |||
| <IsPackable>true</IsPackable> | |||
There was a problem hiding this comment.
The library was marked as packable but never got consumed anywhere else than directly in Arcade.Sdk.csproj. It doesn't make sense to be packaged up.
- Use "Tool" floating TFM properties for msbuild tasks and tools, i.e. Microsoft.DotNet.Arcade.Sdk. - Use "Minimum" floating TFM properties for libraries that support previous framework versions, i.e. XUnitExtensions. - Use "Current" floating TFM properties for libraries that support only the current framework version. Remove "NetToolMinimum" which isn't used and not necessary as our tools/tasks don't multi-target.
ViktorHofer
force-pushed
the
UpdateTFMsAndCopyrightHeaders
branch
from
04eed4d
to
0326de2
Compare
akoeplinger
previously approved these changes
Jan 8, 2024
src/Microsoft.DotNet.Helix/Sdk/tools/Microsoft.DotNet.Helix.Sdk.props
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.